Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABAP] Migrate SAP_COM_0510 to SAP_COM_0948 #4925

Merged
merged 9 commits into from
Jun 10, 2024
Merged

[ABAP] Migrate SAP_COM_0510 to SAP_COM_0948 #4925

merged 9 commits into from
Jun 10, 2024
+44 −45

Conversation

DanielMieg
Copy link
Member

Changes

  • Documentation

@DanielMieg DanielMieg added the ABAP label May 8, 2024
@tiloKo
Copy link
Member

tiloKo commented May 8, 2024

SAP_COM_0510 is mentioned in this error message:

jenkins-library/pkg/abaputils/abaputils.go

Line 63 in 6456f61

var err = errors.New("Parameters missing. Please provide EITHER the Host of the ABAP server OR the Cloud Foundry ApiEndpoint, Organization, Space, Service Instance and a corresponding Service Key for the Communication Scenario SAP_COM_0510")

but as we (SAP_COM_0582) as well as ATC steps are using this function too it might be best to delete it entirely instead of replacing it?

@DanielMieg
Copy link
Member Author

SAP_COM_0510 is mentioned in this error message:

jenkins-library/pkg/abaputils/abaputils.go

Line 63 in 6456f61

var err = errors.New("Parameters missing. Please provide EITHER the Host of the ABAP server OR the Cloud Foundry ApiEndpoint, Organization, Space, Service Instance and a corresponding Service Key for the Communication Scenario SAP_COM_0510")

but as we (SAP_COM_0582) as well as ATC steps are using this function too it might be best to delete it entirely instead of replacing it?

Updated the error message.

@DanielMieg DanielMieg marked this pull request as ready for review May 16, 2024 08:14
@DanielMieg DanielMieg requested a review from a team as a code owner May 16, 2024 08:14
@DanielMieg
Copy link
Member Author

/it

@DanielMieg DanielMieg enabled auto-merge (squash) June 10, 2024 08:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@DanielMieg DanielMieg requested a review from tiloKo June 10, 2024 08:45
tiloKo
tiloKo approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@tiloKo tiloKo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanielMieg DanielMieg merged commit 8eeba2d into SAP:master Jun 10, 2024
13 of 14 checks passed
maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@DanielMieg @maxatsap
[ABAP] Migrate SAP_COM_0510 to SAP_COM_0948 (SAP#4925)
29b90de 
* Migrate SAP_COM_0510 to SAP_COM_0948

* Update error message

* Update error message

* Fix error message in unit test

* Update unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiloKo tiloKo tiloKo approved these changes

Assignees
No one assigned
Labels
ABAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielMieg @tiloKo